Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for query parameters matching to RouteVoter #366

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

yguedidi
Copy link
Contributor

For case where query parameters are used to generate different pages.

For exemple:

  • /tasks?state=open
  • /tasks?state=done
  • /tasks?state=archived
  • ...

src/Knp/Menu/Matcher/Voter/RouteVoter.php Outdated Show resolved Hide resolved
src/Knp/Menu/Matcher/Voter/RouteVoter.php Outdated Show resolved Hide resolved
@yguedidi yguedidi force-pushed the support_query_parameters branch from 85eff9a to e5fe02c Compare January 17, 2022 19:25
@yguedidi yguedidi requested a review from stof January 17, 2022 19:25
@stof stof merged commit 2870e9f into KnpLabs:master Jan 18, 2022
@yguedidi yguedidi deleted the support_query_parameters branch January 18, 2022 08:28
@garak
Copy link
Collaborator

garak commented Jan 18, 2022

I guess we need some updates to docs, right?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants