Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tests: make dataproviders static (part 1) #377

Merged
merged 1 commit into from
May 15, 2023
Merged

tests: make dataproviders static (part 1) #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/Knp/Menu/Tests/Loader/ArrayLoaderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public function testSupports($data, bool $expected): void
/**
* @return array<int, array<int, mixed>>
*/
public function provideSupportingData(): array
public static function provideSupportingData(): array
{
return [
[[], true],
Expand Down
4 changes: 2 additions & 2 deletions tests/Knp/Menu/Tests/Matcher/MatcherTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public function testItemFlag(?bool $flag, bool $expected): void
/**
* @return array<int, array<int, bool|null>>
*/
public function provideItemFlag(): array
public static function provideItemFlag(): array
{
return [
[true, true],
Expand Down Expand Up @@ -121,7 +121,7 @@ public function testVoterIterator(bool $value): void
/**
* @return array<int, array<int, bool>>
*/
public function provideBoolean(): array
public static function provideBoolean(): array
{
return [
[true],
Expand Down
2 changes: 1 addition & 1 deletion tests/Knp/Menu/Tests/Matcher/Voter/RegexVoterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public function testMatching(?string $exp, ?string $itemUri, ?bool $expected): v
/**
* @return array<string, array<int, string|bool|null>>
*/
public function provideData(): array
public static function provideData(): array
{
return [
'no regexp' => [null, 'foo', null],
Expand Down