add resetOption method #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! Can you please fix StyleCI errors, add a test case for this new method and add a little documentation on how to use it in the README.md file? |
alexpozzi
reviewed
Oct 28, 2019
README.md
Outdated
| @@ -80,6 +80,17 @@ $snappy->setOption('toc', true); | |||
| $snappy->setOption('cache-dir', '/path/to/cache/dir'); | |||
| ``` | |||
|
|
|||
| ### Reset options | |||
| Options can be reset to their initial values with `resetOption()` method. | |||
There was a problem hiding this comment.
Suggested change
| Options can be reset to their initial values with `resetOption()` method. | |
| Options can be reset to their initial values with `resetOptions()` method. |
| $media->setOption('disable-javascript', true); | ||
| $media->setOption('no-background', true); | ||
|
|
||
| $media->resetOptions(); |
There was a problem hiding this comment.
Can you assert that options has been set before calling resetOptions?
There was a problem hiding this comment.
Setting option is already tested with testSetOption() method. I don't know we should test it here.
Closed
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
alexpozzi
force-pushed
the
feature/resetOptions
branch
from
14869c4 to
ac05bbc
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.