Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[backport -> release/3.9.x] fix(wasm): execute filter plugins in a consistent order #13967

Open
wants to merge 1 commit into
base: release/3.9.x
Choose a base branch
from

Conversation

team-gateway-bot
Copy link
Collaborator

Automated backport to release/3.9.x, triggered by a label in #13946.

Original description

Summary

Before this change, execution order of filter plugins was subject to ordering returned by the underling DB implementation of kong.db.plugins:each().

This adds an extra step that sorts all discovered filter plugins by name so that execution order is more consistent.

Checklist

  • The Pull Request has tests
  • A changelog file has been created
  • There is a user-facing docs PR

Issue reference

KAG-5851

@team-gateway-bot team-gateway-bot added this to the 3.9.0 milestone Dec 2, 2024
@team-gateway-bot team-gateway-bot added cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/proxy core/wasm Everything relevant to [proxy-]wasm size/L skip-changelog labels Dec 2, 2024
@kikito kikito removed this from the 3.9.0 milestone Dec 3, 2024
Before this change, execution order of filter plugins was subject to
ordering returned by the underling DB implementation of
`kong.db.plugins:each()`.

This adds an extra step that sorts all discovered filter plugins by name
so that execution order is more consistent.

(cherry picked from commit 0d59bd0)
@locao locao force-pushed the backport-13946-to-release/3.9.x branch from a4ef5fd to ec755a5 Compare January 14, 2025 13:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/proxy core/wasm Everything relevant to [proxy-]wasm size/L skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants