Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tests(helpers): reorganize grpc target service #14045

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gszr
Copy link
Member

@gszr gszr commented Dec 23, 2024

Summary

This PR accomplishes a few things related to gRPC testing:

  • Reorganize the mock targetservice service we use in some gRPC tests
  • Add a Makefile and simplify Lua helpers to build the code
  • Add a new EchoHeaders grpc RPC, to be used in tests that need to verify headers sent by Kong to the gRPC upstream (similar to httpbin's /anything)
  • Use the new RPC in :authority pseudo-header tests

@gszr gszr requested a review from brentos December 23, 2024 16:50
@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Dec 23, 2024
@gszr gszr force-pushed the refactor/add-echo-headrs-rpc branch from 6aa8f6c to 2b3dcff Compare December 23, 2024 16:53
@gszr gszr force-pushed the refactor/add-echo-headrs-rpc branch from 2b3dcff to 96dee67 Compare January 17, 2025 11:19
@gszr gszr changed the base branch from fix/grpc-web-and-gateway-trailers to master January 17, 2025 11:19
@gszr gszr force-pushed the refactor/add-echo-headrs-rpc branch 3 times, most recently from 28c71c1 to 6ff7e9d Compare January 22, 2025 13:33
@gszr gszr force-pushed the refactor/add-echo-headrs-rpc branch from 6ff7e9d to 470db20 Compare January 22, 2025 14:09
@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Jan 22, 2025
@gszr gszr force-pushed the refactor/add-echo-headrs-rpc branch 3 times, most recently from 697b918 to 0ad5025 Compare January 22, 2025 21:21
@gszr gszr marked this pull request as draft January 22, 2025 22:52
@gszr gszr force-pushed the refactor/add-echo-headrs-rpc branch 2 times, most recently from 88f2cf4 to d837743 Compare January 23, 2025 16:36
gszr added 3 commits January 23, 2025 14:03
Add a makefile to grpc target service.
This will improve testability and reliability of some gRPC tests.
Replace template-based mock grpc service with actual gRPC service to
test for `:authority` headers.
@gszr gszr force-pushed the refactor/add-echo-headrs-rpc branch from d837743 to e42139a Compare January 23, 2025 17:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed size/L skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant