Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(utils) accept hosts ending in dots #6864

Merged
merged 1 commit into from
Mar 16, 2021
Merged

fix(utils) accept hosts ending in dots #6864

merged 1 commit into from
Mar 16, 2021

Conversation

locao
Copy link
Contributor

@locao locao commented Feb 24, 2021 •
edited
Loading

According to RFC 3986 - section 3.2.2 hosts can end in dots

Kong/lua-resty-dns-client#122 is a sister PR and this one should not be merged before the lua-resty-dns-client release with that fix included.

@locao locao force-pushed the fix/fqdn_ending_in_dots branch from f85591b to 14710da Compare February 24, 2021 15:33
kikito
kikito approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@kikito kikito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor typo notice

gszr
gszr previously requested changes Mar 4, 2021
View reviewed changes
Copy link
Member

@gszr gszr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this PR target next instead, as we do not usually do library bumps in master?

@locao locao force-pushed the fix/fqdn_ending_in_dots branch from 14710da to 6cddf78 Compare March 11, 2021 14:36
@locao locao changed the base branch from master to next March 11, 2021 14:37
@locao locao force-pushed the fix/fqdn_ending_in_dots branch from 6cddf78 to 8fcaad0 Compare March 11, 2021 14:38
@Tieske
Copy link
Member

Tieske commented Mar 12, 2021

imo, the lib only had a bugfix, so master should be fine as well, no?

@gszr gszr dismissed their stale review March 15, 2021 16:14

discussed with the team, let's go ahead with the bump in master

@locao locao force-pushed the fix/fqdn_ending_in_dots branch from 8fcaad0 to 199f067 Compare March 16, 2021 14:08
@locao locao changed the base branch from next to master March 16, 2021 14:09
@locao locao merged commit 4b2b531 into master Mar 16, 2021
@locao locao deleted the fix/fqdn_ending_in_dots branch March 16, 2021 14:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kikito kikito kikito approved these changes

@gszr gszr gszr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@locao @Tieske @kikito @gszr