Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that operations without empty description of
operation.input
does not work at all. I've addedif
intoaws/init.lua
andaws/request/build.lua
s3_patch
(aws/init.lua
) seems to be not quite well written. When we changerequest.host
we should changerequest.headers.Host
as well, because of the signature. Also, operations such aslistObjectsV2
and other meta operations requires non-empty path.The last part is not quite good :( It would be nice if we could parse xml output into Lua tables, we have
operation.output
descriptions for it. To do that we need to distinguish streaming content and API responses.Streaming content (
GetObject
mostly, maybeGetObjectTorrent
) it would be better to not read entire body into Lua memory, but providebody_reader
fromresty.http
instead. Although I'm not sure that this behaviour should be fixed the way I did itP.S. raw-api contains 17
"streaming":true
lines, but necessarily all of the Outputs