This repository was archived by the owner on Jul 11, 2023. It is now read-only.
feat(balancer) option to return nested SRV name as hostname #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tieske
force-pushed
the
srv-name
branch
3 times, most recently
from
0091920 to
d47b994
Compare
…hostname BREAKING: mostly the effect is the since `useSRVname` hasn't been released yet. The breaking part is that in case an IP address is added through `addHost`, the returned hostname by `getPeer` will now be `nil` where it previously was the IP address. Semantically the return value changed from the 'host' to the 'host-header' but as stated; changes only if it was an IP address to begin with.
locao
approved these changes
May 13, 2020
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the balancer to return a host-header.
So far the returned "host" was always the name of the host as it was added to the balancer by calling
addHost(). With this PR there is a change between the Host as added and the host-header to be used on a request.getPeer()will return the host-header instead of the name. The breaking change here is that if the name as added is an IP address, then the host-header returned will benil. Otherwise, with all defaults everything will be the same.useSRVname(falseby default), which if set, will instruct the returned Host-header to be the name inside an SRV record. If not and SRV record, then it will return the hostname as added to the balancer (as before).