Skip to content

Conversation

holgerbrandl
Copy link

Adjusted Passenger schema to reflect nullability of age attribute. With the fix, we can also use filter: .filter{ it[Passenger::age]!=null}

Adjusted Passenger schema to reflect nullability of age attribute. With the fix, we can also use filter: `  .filter{ it[Passenger::age]!=null}`
@koperagen
Copy link
Collaborator

koperagen commented Aug 29, 2022

Hi! It's a bit trickier :) This sample is copy-pasted by korro task from

It should be changed there as well

@Jolanrensen Jolanrensen added this to the 0.9.0 milestone Nov 28, 2022
@Jolanrensen Jolanrensen self-assigned this Nov 28, 2022
@Jolanrensen
Copy link
Collaborator

There are more things that aren't in the actual titanic.csv file:
The delimiter is wrong, survived is 1/0, not a boolean, there are more attributes etc. So I think it's intentional age is not Int?. It's just an example.
@koperagen should these docs actually work with our titanic.csv?

@Jolanrensen Jolanrensen removed their assignment Nov 28, 2022
@Jolanrensen Jolanrensen added the documentation Improvements or additions to documentation (not KDocs) label Nov 28, 2022
@Jolanrensen Jolanrensen removed this from the 0.9.0 milestone Dec 15, 2022
@zaleslaw zaleslaw self-requested a review May 11, 2023 10:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation (not KDocs)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants