Fix cancellation support for Mutex when lock becomes available between tryLock and suspending. #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n tryLock and suspending.
qwwdfsad
added a commit
that referenced
this pull request
Nov 17, 2020
…ch of slow-path in Mutex/Semaphore Fixes #2390
|
Thanks! Opened #2396 with semaphore fix and better solution, will merge it instead |
This was referenced Mar 12, 2021
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A synchronous call to continuation.resume in suspendLock doesn't preclude a cancellation race, so it needs the same care as during the passing of ownership that takes place in unlock.
Fixes #2380