Skip to content

Change order of handlers in JobSupport and CancellableContinuation #418

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2018
Merged

Change order of handlers in JobSupport and CancellableContinuation #418

merged 1 commit into from
Jul 10, 2018

Conversation

qwwdfsad
Copy link
Member

@qwwdfsad qwwdfsad commented Jul 3, 2018

  1. Invoke handlers before dispatching in CancellableContinuation to make behaviour timing-independent and Unconfined doesn't produce unexpected results
  2. Invoke onCancellation -> handlers -> onCompletion in Job to make behaviour timing-independent

Fixes #415

@qwwdfsad
Change order of handlers in JobSupport and CancellableContinuation
0a251f5 
1) Invoke handlers before dispatching in CancellableContinuation to make behaviour timing-independent and Unconfined doesn't produce unexpected results
2) Invoke onCancellation -> handlers -> onCompletion in Job to make behaviour timing-independent

Fixes #415
@elizarov elizarov merged commit b10287e into develop Jul 10, 2018
@elizarov elizarov deleted the fix-handlers-order branch July 10, 2018 18:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwwdfsad @elizarov