Secure path handling #343
Merged
Secure path handling #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 24, 2015 14:32
The old implementation failed to sanitize URIs like ".", "..", "../.." or "//"
Do no rely on the HTTP server
Before the program crashed implicitly
See a7b47f075499a1e1b40539bc1fa872a3ab77a204 The check for "." is now needless because the sane path is always absolute. ```path.replace(os.sep, "/")``` is only relevant for the (multi)filesystem backend and should be there.
With the old implementation on Windows a path like "/c:/file/ignore" got converted to "c:\file" and allowed access to files outside of FOLDER
Component names are controlled by the user and without this checks access to arbitrary files is possible if the multifilesystem backend is used.
This only becomes a problem if the OS/filesystem allows / in filenames or . respectively .. as filenames.
|
That's a serious one. Do you have other security-related issues coming? I'll have to release a new version after that. Thank you again! |
|
No, I've not. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of issues with dodgy path handling:
Paths like
..,../..or//are not sanitized correctlyThe program crashes if a path doesn't start with
base_prefixinstead of showing an error messageOn MS Windows the filesystem backend allows access to the first level of files on a drive.
e.g. the path
/c:/filename/dummygets converted toc:\filenameThe multifilesystem backend allows access to arbitrary files on all platforms.
e.g. set the UID of a ics file to
/dev/null