fix an issue with message deletes

Kraigie · May 18, 2024 · e9e6b2b · e9e6b2b
1 parent 58f1dbc
commit e9e6b2b
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 14 deletions.
diff --git a/lib/nostrum/cache/message_cache.ex b/lib/nostrum/cache/message_cache.ex
@@ -65,7 +65,7 @@ defmodule Nostrum.Cache.MessageCache do
 
   Expects the deleted message to be returned if it was found.
   """
-  @callback delete(Channel.id(), Message.id()) :: Message.t() | :noop
+  @callback delete(Channel.id(), Message.id()) :: Message.t() | nil
 
   @doc """
   Deletes multiple messages from the cache, any message id's given

diff --git a/lib/nostrum/cache/message_cache/mnesia.ex b/lib/nostrum/cache/message_cache/mnesia.ex
@@ -150,7 +150,7 @@ if Code.ensure_loaded?(:mnesia) do
 
     @impl MessageCache
     @doc "Removes a message from the cache."
-    @spec delete(Channel.id(), Message.id()) :: Message.t() | :noop
+    @spec delete(Channel.id(), Message.id()) :: Message.t() | nil
     def delete(channel_id, message_id) do
       :mnesia.activity(:sync_transaction, fn ->
         case :mnesia.read(@table_name, message_id, :write) do
@@ -162,7 +162,7 @@ if Code.ensure_loaded?(:mnesia) do
             message
 
           _ ->
-            :noop
+            nil
         end
       end)
     end
@@ -176,7 +176,7 @@ if Code.ensure_loaded?(:mnesia) do
     def bulk_delete(channel_id, message_ids) do
       Enum.reduce(message_ids, [], fn message_id, list ->
         case delete(channel_id, message_id) do
-          :noop ->
+          nil ->
             list
 
           message ->

diff --git a/lib/nostrum/cache/message_cache/noop.ex b/lib/nostrum/cache/message_cache/noop.ex
@@ -34,7 +34,7 @@ defmodule Nostrum.Cache.MessageCache.Noop do
   def update(payload), do: {nil, Util.cast(payload, {:struct, Message})}
 
   @impl MessageCache
-  def delete(_channel_id, _message_id), do: :noop
+  def delete(_channel_id, _message_id), do: nil
 
   @impl MessageCache
   def bulk_delete(_channel_id, _message_ids), do: []

diff --git a/lib/nostrum/shard/dispatch.ex b/lib/nostrum/shard/dispatch.ex
@@ -253,13 +253,8 @@ defmodule Nostrum.Shard.Dispatch do
     do: {event, MessageCache.create(p), state}
 
   def handle_event(:MESSAGE_DELETE = event, p, state) do
-    case MessageCache.delete(p.channel_id, p.id) do
-      {:ok, message} ->
-        {event, MessageDelete.to_struct(p, message), state}
-
-      :noop ->
-        {event, MessageDelete.to_struct(p), state}
-    end
+    deleted_message = MessageCache.delete(p.channel_id, p.id)
+    {event, MessageDelete.to_struct(p, deleted_message), state}
   end
 
   def handle_event(:MESSAGE_DELETE_BULK = event, p, state) do

diff --git a/test/nostrum/cache/message_cache_meta_test.exs b/test/nostrum/cache/message_cache_meta_test.exs
@@ -108,8 +108,8 @@ defmodule Nostrum.Cache.MessageCacheMetaTest do
       end
 
       describe "delete/2" do
-        test "returns :noop on an uncached message" do
-          assert :noop == @cache.delete(10_258_109_258_109_258_125, 10_258_109_258_109_258_125)
+        test "returns nil on an uncached message" do
+          assert nil == @cache.delete(10_258_109_258_109_258_125, 10_258_109_258_109_258_125)
         end
       end
     end