Convert shard sessions into state machines #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchristgit
force-pushed
the
gateway-state-machine
branch
from
1053f88 to
f30c7f9
Compare
This fixes the previous implementation's problem of retrying connections indefinitely without any proper handling of errors. Ratelimiting will be added separately.
jchristgit
force-pushed
the
gateway-state-machine
branch
from
f30c7f9 to
e5c6964
Compare
Th3-M4jor
reviewed
Jun 2, 2023
|
This is a great idea. I have implemented it.
|
Similar reason as for the ratelimiter
jchristgit
force-pushed
the
gateway-state-machine
branch
from
7e90fb3 to
0b66b26
Compare
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the previous implementation's problem of retrying connections indefinitely without any proper handling of errors. Ratelimiting will be added separately.