Move ChannelCache to DMChannelCache #554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jb3
force-pushed
the
jb3/dm-channel-cache
branch
from
a518059 to
297cd1d
Compare
|
Closing this since we have realized this PR can never populate. I will re-open a PR removing this cache. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we modified the behaviour of the DMChannelCache to only cache DM Channels it is a good idea to amend the naming of the cache itself to avoid confusion, as well as fleshing out the documentation to further make it clear how caches are expected to operate.
Closes #537