Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add admonition documenting lack of DM channel caching #561

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Add admonition documenting lack of DM channel caching #561

merged 2 commits into from
Apr 24, 2024

Conversation

jb3
Copy link
Collaborator

@jb3 jb3 commented Apr 24, 2024

Adds the following admonition to explain why DM channels are not/cannot be cached:

image

@jchristgit jchristgit self-assigned this Apr 24, 2024
@jchristgit jchristgit self-requested a review April 24, 2024 19:14
jchristgit
jchristgit requested changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

lib/nostrum/struct/channel.ex Outdated Show resolved Hide resolved
@jb3 @jchristgit
Fix typo
d17ff3d 
Co-authored-by: jchristgit <jc@jchri.st>
@jb3
Copy link
Collaborator Author

jb3 commented Apr 24, 2024

Fixed through web UI, just squash merge when ready to get rid of the double-commit.

@jchristgit jchristgit merged commit 659fc6a into master Apr 24, 2024
7 checks passed
@jchristgit jchristgit deleted the jb3/dm-caching-clarity branch April 24, 2024 19:19
@jchristgit
Copy link
Collaborator

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jchristgit jchristgit jchristgit requested changes

Assignees

@jchristgit jchristgit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jb3 @jchristgit