Only attempt resume if the gateway says we can #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jb3
requested changes
May 3, 2024
broman
approved these changes
May 3, 2024
it's intentional although I haven't seen the warning until now. I will update this to underscore it |
Per [1] and [2], if the `d` field is set to `true` we may attempt to resume again with the same session, otherwise we should not. nostrum would previously loop on trying to resume on the same session after an invalid session was sent, and the behaviour of simply sending an identify payload did not work as expected. When the session that we try to resume with is invalid, perform a reconnect and do the whole handshake, greeting and meeting the parents thing all over again. [1]: https://discord.com/developers/docs/topics/gateway-events#invalid-session [2]: https://discord.com/developers/docs/topics/gateway#resuming
jchristgit
force-pushed
the
try-resume-only-if-possible
branch
from
035839f to
e303f2b
Compare
jb3
approved these changes
May 4, 2024
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per 1 and 2, if the
dfield is set totruewe may attempt toresume again with the same session, otherwise we should not. nostrum
would previously loop on trying to resume on the same session after an
invalid session was sent, and the behaviour of simply sending an
identify payload did not work as expected. When the session that we try
to resume with is invalid, perform a reconnect and do the whole
handshake, greeting and meeting the parents thing all over again.