Log at INFO level when shard connection is up #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make logs such as this:
[info] Asked to reconnect with session SESSION
[info] Re-established websocket connection
[info] Resuming on shard session SESSION
[info] Asked to reconnect with session SESSION
[info] Re-established websocket connection
[info] Resuming on shard session SESSION
Less confusing by ensuring the user knows we successfully resumed.
jb3
approved these changes
May 4, 2024
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make logs such as this:
Less confusing by ensuring the user knows we successfully resumed.