Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor executable checks and add version check for non-forked youtube-dl #594

Merged
merged 2 commits into from
May 12, 2024

Conversation

BrandtHill
Copy link
Contributor

Don't check ytdl/streamlink executables if ffmpeg is not configured
Add one-time version check for youtube-dl if not suppressed at compile time
Remove useless stuff from nostrum config
Stop starting 2 Dummy consumers in dev since events are duplicated with :pg

Copy link
Collaborator

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for one minor suggestion.

lib/nostrum/voice.ex Outdated Show resolved Hide resolved
Copy link
Collaborator

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jchristgit jchristgit merged commit ace2e2f into Kraigie:master May 12, 2024
9 checks passed
@jchristgit
Copy link
Collaborator

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants