-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(shard): manually shard connect and reconnect #596
feat(shard): manually shard connect and reconnect #596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! This is a really cool feature!
I've tested it locally and all seems to be working solid, my only request is documentation on the new public facing APIs that enable this functionality.
It doesn't need to be incredibly comprehensive but an overview of what happens, what is returned and maybe a little overview of "how it works" (i.e. that it stores the resume information and then opens a new connection with that RESUME payload).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks! |
Nice! This looks really good! Nostrum! |
This PR provides the user with functions to connect/reconnect/disconnect to the gateway.
In our use case, this allows for zero downtime updates.
This would also advance Issue #542.