Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump CI to OTP 27 #601

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Bump CI to OTP 27 #601

merged 2 commits into from
Jun 20, 2024

Conversation

jb3
Copy link
Collaborator

@jb3 jb3 commented May 21, 2024

Move from the OTP 27 release candidate to the OTP 27 stable release.

@jchristgit jchristgit self-assigned this May 24, 2024
@jchristgit
Copy link
Collaborator

This fails.

Error: Requested Elixir / Erlang/OTP version (1.16 / 27) not found in version list (did you check Compatibility between Elixir and Erlang/OTP?).Elixir and Erlang/OTP compatibility can be found at: https://hexdocs.pm/elixir/compatibility-and-deprecations.html

Do we need to run some Elixir prerelease?

@jb3
Copy link
Collaborator Author

jb3 commented May 24, 2024

@jchristgit

Known for now, it pends on Elixir upstream deciding which OTP versions are supported by which Elixir versions.

It might come in a 1.16 patch release, it might come in the 1.17 release. I was going to hold this open for a month or so, if no updates after that I will recreate once we know more.

For now, I'll revert it to draft.

@jb3 jb3 marked this pull request as draft May 24, 2024 17:18
@jchristgit
Copy link
Collaborator

@jb3 I think this should work with 1.17, should we retry?

@jb3
Copy link
Collaborator Author

jb3 commented Jun 19, 2024

It will need some changes to the matrix I think, will give it a go in a second.

@jb3 jb3 force-pushed the jb3/otp-27 branch 2 times, most recently from 7f50af8 to 24f7449 Compare June 19, 2024 19:02
@jb3
Copy link
Collaborator Author

jb3 commented Jun 19, 2024

Well, this looks like a bug with Credo on 1.17-otp-27
image

@jb3
Copy link
Collaborator Author

jb3 commented Jun 19, 2024

Bumping Credo version works. I am going to rewrite some commits since we now also add 1.17 into CI.

@jb3 jb3 marked this pull request as ready for review June 19, 2024 19:12
@jb3 jb3 requested a review from jchristgit June 19, 2024 19:12
jb3 added 2 commits June 19, 2024 20:19
- Move from the OTP 27 release candidate to the OTP 27 stable release.
- Add Elixir 1.17 to our testing matrix.

OTP 27 is only tested against Elixir 1.17, until we potentially get
patch releases for earlier versions to explicitly support/add those
build combinations.
@jchristgit jchristgit merged commit db1fd45 into master Jun 20, 2024
10 checks passed
@jchristgit
Copy link
Collaborator

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants