Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ensure user struct is casted properly before updating ets cache #610

Conversation

Th3-M4jor
Copy link
Contributor

Discovered that the user cache did not always have a properly casted user struct after an update, this fixes that as well as makes it so that updated maps are merged in a way where missing values don't replace existing ones with nil

@Th3-M4jor Th3-M4jor force-pushed the bugfix-user-cache-not-casting-before-saving-all-branches branch from 71d9ac1 to 345c61e Compare June 22, 2024 02:37
@Th3-M4jor Th3-M4jor force-pushed the bugfix-user-cache-not-casting-before-saving-all-branches branch from 345c61e to 38b9437 Compare June 22, 2024 02:41
Copy link
Collaborator

@jb3 jb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, do we need to do this style of adding to_struct/2 definition to all cached objects? (Do we already do this?).

@jb3 jb3 merged commit 12f3dd0 into Kraigie:master Jul 18, 2024
10 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants