Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

GC concurrent issue potential fix #1

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Conversation

tosbaha
Copy link

@tosbaha tosbaha commented Dec 3, 2019

Fixes from @pratikpatel39 according to this issue

@Kudo
Copy link
Owner

Kudo commented Dec 17, 2019

Thank you @tosbaha, do you mind to put the original WebKit patch directly? It would be better to appreciate original author's work.
It seems your branch has the permissions for me to edit directly. If you don't mind, I could edit on your branch and then merge your PR.

@tosbaha
Copy link
Author

tosbaha commented Dec 17, 2019

Hi @Kudo , I got the combined patches from the linked thread. Which actually links to https://trac.webkit.org/changeset/251307/webkit Since the patches were pointing to the different directories, @pratikpatel39 fixed the patches and unified the patch. I don't know how can I put the original WebKit patch directly. I checked the patches in this repository there were no authors etc. Please edit the PR as you please.

@Kudo
Copy link
Owner

Kudo commented Dec 18, 2019

Sorry to make you confuse. I was talking about including the CHANGELOG.
Will modify your PR and merge directly. Thank you very much.

@Kudo Kudo merged commit 940c21e into Kudo:jsc_2_26_1 Dec 18, 2019
@Kudo
Copy link
Owner

Kudo commented Dec 18, 2019

I've modified your PR and merged back to jsc_2_26_1 branch.
Will follow up to merge this patch to my develop branch and hopefully to publish new version soon.
Thank you.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants