[NodeBundle] Fix node translations not getting a URL set when using structure nodes #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't run the unit tests as an exception was thrown with the message: A callable is expected in AnnotationRegistry::registerLoader. I copied the app/autoload.php from the bundles standard edition project which seemed to have solved the issue.
|
When will you release this? |
|
End of march I will tag 3.1, this will be in it. |
roderik
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution for issue #174
I am unsure if the fix for the
autoload.php.distis the way to go.I copied it from
app/autoload.php.I couldn't run the tests locally without it though.
I have PHP 5.5.9 installed.