[AdminBundle,GeneratorBundle,NodeBundle,UtilitiesBundle] Change slugifier into service #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
woutervandamme
commented
May 12, 2015
woutervandamme
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | #84 |
woutervandamme
force-pushed
the
feature/slugifier
branch
from
e264923 to
c7a24d5
Compare
|
@woutervandamme check the travis build failure |
| @@ -296,7 +296,7 @@ public function createNodeTranslationFor(HasNodeInterface $hasNode, $lang, Node | |||
| ->setNode($node) | |||
| ->setLang($lang) | |||
| ->setTitle($hasNode->getTitle()) | |||
| ->setSlug(Slugifier::slugify($hasNode->getTitle(), '')) | |||
| ->setSlug($hasNode->getTitle(), '') | |||
woutervandamme
force-pushed
the
feature/slugifier
branch
4 times, most recently
from
7ae7e88 to
a83d070
Compare
| @@ -8,6 +8,18 @@ | |||
|
|
|||
| class UtilitiesTwigExtension extends Twig_Extension | |||
| { | |||
| /** | |||
| * @var Slugifier | |||
woutervandamme
force-pushed
the
feature/slugifier
branch
2 times, most recently
from
5151a46 to
81e0ed2
Compare
|
@woutervandamme please rebase on top of master, thanks! |
added slugifier service to fixtures add slugifier service to NodeBundle updated slugifier tests inject slugifier into utilitiesTwigExtension twigExtension now works with the slugifier service removed @Covers in slugifierTest implemented slugifierInterface
woutervandamme
force-pushed
the
feature/slugifier
branch
from
81e0ed2 to
1541fce
Compare
|
code review: ok |
roderik
pushed a commit
that referenced
this pull request
May 26, 2015
[AdminBundle,GeneratorBundle,NodeBundle,UtilitiesBundle] Change slugifier into service
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.