[FormBundle] Order the FormSubmissionFields like their respective PageParts on the FormPage #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
May 27, 2015
ghost
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | yes |
| Deprecations? | no |
| Fixed tickets | 445 |
ghost
added
| $em = $this->getDoctrine()->getManager(); | ||
| $nodeTranslation = $em->getRepository('KunstmaanNodeBundle:NodeTranslation')->find($nodeTranslationId); | ||
| $formSubmission = $em->getRepository('KunstmaanFormBundle:FormSubmission')->find($submissionId); | ||
| $formSubmissionFields = $em->getRepository('KunstmaanFormBundle:FormSubmissionField')->getFieldsOrderedBySequence($formSubmission); |
There was a problem hiding this comment.
Why would you fetch them separately? The fields are a property of FormSubmission, and can be sorted there according to their sequence by adding a simple Doctrine annotation. cfr. http://doctrine-orm.readthedocs.org/en/latest/tutorials/ordered-associations.html
There was a problem hiding this comment.
Aha! That's indeed what I needed but didn't find right away. Will fix tomorrow. Thx!
I clearly need to fix the tests as well, oops.
|
@kln3wrld please squash |
roderik
changed the title
|
@kln3wrld put the upgrade info in upgrade-3.2, not in upgrade. Then I can merge it |
roderik
pushed a commit
that referenced
this pull request
Jun 2, 2015
[FormBundle] Order the FormSubmissionFields like their respective PageParts on the FormPage
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.