Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: implement variable set #1344

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

liu-hm19
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR implements a variable set of kusion server to manage the global variables for kusion module generator.

Which issue(s) this PR fixes:

Fixes #1334

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 self-assigned this Dec 17, 2024
@liu-hm19 liu-hm19 added the kind/feature Categorizes issue or PR as related to a new feature label Dec 17, 2024
@liu-hm19 liu-hm19 added this to the v0.14.0 milestone Dec 17, 2024
@liu-hm19 liu-hm19 force-pushed the implement-variable-set branch from 4ce8d44 to f8786d1 Compare December 18, 2024 06:27
@ffforest ffforest modified the milestones: v0.14.0, v0.15.0 Feb 12, 2025
@liu-hm19 liu-hm19 force-pushed the implement-variable-set branch from 1a9a1ba to fc8dc41 Compare February 12, 2025 09:04
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13304889274

Details

  • 78 of 891 (8.75%) changed or added relevant lines in 22 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.4%) to 46.415%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/server/handler/render.go 10 12 83.33%
pkg/server/route/route.go 26 32 81.25%
pkg/server/manager/variable/util.go 0 8 0.0%
pkg/server/manager/variableset/util.go 0 8 0.0%
pkg/server/middleware/message.go 0 8 0.0%
pkg/domain/entity/variable_set.go 0 11 0.0%
pkg/domain/entity/variable.go 0 14 0.0%
pkg/infra/persistence/variable_set_model.go 0 19 0.0%
pkg/infra/persistence/util.go 0 20 0.0%
pkg/infra/persistence/variable_model.go 0 23 0.0%
Totals Coverage Status
Change from base Build 13177852365: -1.4%
Covered Lines: 11382
Relevant Lines: 24522

💛 - Coveralls

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: kusion server supports a variable set to manage the global variables for Kusion module generators
3 participants