Fix to connect Amazon S3 compatible endpoints with custom auth region #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I realised that it is not possible to connect to specific S3 compatible endpoints (such as those provided by OVH).
When trying to connect, you get the following error:
where 'xxx' is the name of the region for your S3 endpoint (for OVH, it can be "gra", "uk", ...). This issue also happened elsewhere see here.
I propose a solution similar to the one in the link. A new field 'Override Auth Region' is added below the Other URL field and is only typable when dealing with endpoints different from Amazon. When you type your region, it works as expected. If you type nothing, it should do nothing.
As I don't own another S3 compatible bucket (non-Amazon and non OVH), I am not able to confirm that it didn't break the behavior for these.
I also don't know if the issue is specific to OVH.
Best regards.