Please use a delimiter between org/team names #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please use a delimiter between org/team names in the log. Expected: Log messages will not be hard to distinguish due to org/team names not being represented as discreet units. Actual: Org/team names are combined into a single string which must be manually separated. Reproducing: Log into nexus via Github oauth using an account with multiple teams in an organization (e.g org1/team1 and org1/team2). Observe that in the log the organization and team names are combined (e.g. org1/team1org1/team2).
ghost
mentioned this pull request
|
Very helpful improvement! Thank you! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please use a delimiter between org/team names in the log.
Expected:
Log messages will not be hard to distinguish due to org/team names not being represented as discreet units.
Actual:
Org/team names are combined into a single string which must be manually separated.
Reproducing:
Log into nexus via Github oauth using an account with multiple teams in an organization (e.g org1/team1 and org1/team2). Observe that in the log the organization and team names are combined (e.g. org1/team1org1/team2).