Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add quotes to jsregexp make commands #1099

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

louis-vs
Copy link
Contributor

Resolves #1098

@L3MON4D3
Copy link
Owner

Ahh yeah of course 👍
Mentioning it for others who may stumble slightly: $(shell ...) inside single-quotes is expanded, unlike in bash!

Thank you for the fix!

@L3MON4D3 L3MON4D3 merged commit de5c115 into L3MON4D3:master Dec 27, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make install_jsregexp fails when repo path has a space
2 participants