Implement methods for conversion between temporal and spatial field presentations #126

hightower8083 · 2023-04-21T20:40:39Z

This PR adds to main Laser class the methods export_to_z and import_from_z for conversion between temporal and spatial field presentations, and the test script for these methods.

Additionally this PR includes:

fix of the use of fft method in propagator to comply with the used envelope definition: ifft with "backward" normalization should be used to convert the field to the frequency domain
direct import of c from scipy.constants is using instead of scc.c
removed the requirement for the specific version of axiprop

added and tested the wrappers for z2t and t2z convertors

…tions of lasy objects removed absorbers and useless stuff fixed bug with the phase terms for envelopes replaced `scc.c` with `c` for the cleared code added docstrings to the new methods

for more information, see https://pre-commit.ci

…o the methods, fixed the in-code comments, removed unnessecary variables

for more information, see https://pre-commit.ci

…t2z-z2t

MaxThevenet

Thanks for this PR!! See comments below. Furthermore, could you add a CI test? Suggestions:

in 3D, for the Gaussian example that you shared in your figures, generate a beam with lasy (so, time representation), call export_to_z, and compare with theory (the tolerance will ofc depend on the resolution, but it should be tight enough for the t representation to largely fail the test). Then you could call import_from_z, and compare with the original profile.
Same test in RZ, as these use quite different functions.

lasy/laser.py

Co-authored-by: Maxence Thévenet <maxence.thevenet@desy.de>

MaxThevenet · 2023-05-15T13:07:30Z

Could you have a look at the pre-commit.ci issue?

MaxThevenet · 2023-05-19T06:00:07Z

Thanks! as described in the message above, could you add a CI test for this PR? This should be consistent with what was discussed also with @RemiLehe at a LASY meeting a few weeks back.

added dots at the end of the first docstring for pre-commit check

added a draft test for `t2z2t` conversion

…nto t2z-z2t

bugfixes draft test is fixed

for more information, see https://pre-commit.ci

tests/test_t2z2t.py

removed unused laser object

hightower8083 · 2023-05-24T19:12:29Z

@MaxThevenet, @RemiLehe

I've added a simple test where we take field in t domain, export it to z domain and compare (with looser tolerance) with the original field considering approximationt=-z/c (for this I consider a large beam), then transform it back to t domain, and compare it to the original field (with higher accuracy).

I've also used for convenience a new axiprop container class which handles spectral-temporal transforms, axes and boundaries. This makes code clearer, and i'm thinking of passing to this approach in the rest of axiprop-related methods. Please take a look at the code in export_to_z and tell me what you think.

I've also removed forced version from axiprop in pip setup

MaxThevenet

Thanks for adding the test! See comment below.

MaxThevenet · 2023-05-30T14:58:43Z

tests/test_t2z2t.py

+    assert np.allclose(
+        laser_t_in.field.field[ind0], laser_t_out.field.field[ind0], atol=1e-8
+    )
+    assert np.allclose(Field_approx, Field_orig, atol=2e-3)


Are Field_orig and Field_approx supposed to be close to each other in general? Otherwise, could we compare instead something like (pseudo-code) laser_t_in and laser_z*(1+z**2/zR**2)**.5 for a beam with a length = zR centered around t=0 and z=0? These should be close.

…ntations defined the checks for `t-z-t` numerical correctness and analytical check for `z` representation

for more information, see https://pre-commit.ci

hightower8083 · 2023-06-27T15:42:16Z

Hey @MaxThevenet , I've revised the test
Now operates with a case with strong difference with t and z representations. It verify the reversibility of t-z-t transform and also compares the obtained z representation with theory.
On my machine tests runs fine, but for some reason fails in CI and I fail to understand the reason. Could you check how it runs on your side and let me know if you have any idea how to debug the unittest ?

… comparison

…nto t2z-z2t

for more information, see https://pre-commit.ci

lasy/laser.py

MaxThevenet

Looks great, thanks for this PR! Below are minor typos fixes.

lasy/laser.py

tests/test_t2z2t.py

hightower8083 and others added 3 commits April 20, 2023 18:24

fixed formalism for ifft and fft in the propagator (bugfix)

94e1ba5

added and tested the wrappers for z2t and t2z convertors

changed converters interfaces for easier use and more coherent defini…

443bbae

…tions of lasy objects removed absorbers and useless stuff fixed bug with the phase terms for envelopes replaced `scc.c` with `c` for the cleared code added docstrings to the new methods

[pre-commit.ci] auto fixes from pre-commit.com hooks

f38d14c

for more information, see https://pre-commit.ci

hightower8083 added the new feature request or implementation of a new feature label Apr 22, 2023

hightower8083 and others added 4 commits April 22, 2023 12:21

another round of cleanup: removed absorbers, made propagators local t…

20d8804

…o the methods, fixed the in-code comments, removed unnessecary variables

[pre-commit.ci] auto fixes from pre-commit.com hooks

c369d32

for more information, see https://pre-commit.ci

removed import of unused scc module (fails pyflakes)

bbd7ed7

Merge branch 't2z-z2t' of https://github.com/hightower8083/lasy into …

8d151e8

…t2z-z2t

RemiLehe self-requested a review April 24, 2023 16:35

hightower8083 requested a review from MaxThevenet April 24, 2023 16:59

MaxThevenet reviewed Apr 26, 2023

View reviewed changes

hightower8083 mentioned this pull request May 9, 2023

set axiprop to be installed from pip #135

Merged

Apply suggestions from code review

b975737

Co-authored-by: Maxence Thévenet <maxence.thevenet@desy.de>

hightower8083 and others added 6 commits May 22, 2023 10:06

Update laser.py

8946582

added dots at the end of the first docstring for pre-commit check

fixed a possible bug in the box origin phase application

4445ce0

added a draft test for `t2z2t` conversion

Merge branch 'development' of https://github.com/hightower8083/lasy i…

2846eaf

…nto t2z-z2t

implemented apxiprop container in export_to_z method

efbffc8

bugfixes draft test is fixed

removed version from axiprop in requirements

ee7cef9

[pre-commit.ci] auto fixes from pre-commit.com hooks

8c29a40

for more information, see https://pre-commit.ci

github-advanced-security bot found potential problems May 24, 2023

View reviewed changes

tests/test_t2z2t.py Fixed Show fixed Hide fixed

Update test_t2z2t.py

661289b

removed unused laser object

MaxThevenet reviewed May 30, 2023

View reviewed changes

hightower8083 and others added 2 commits June 27, 2023 17:26

revised the test to have stong difference between t and z represe…

e8b40d1

…ntations defined the checks for `t-z-t` numerical correctness and analytical check for `z` representation

[pre-commit.ci] auto fixes from pre-commit.com hooks

7305cff

for more information, see https://pre-commit.ci

hightower8083 added 2 commits June 28, 2023 15:09

set time axis to include t=0 point which is needed for the accurate…

616e4e8

… comparison

Merge branch 'development' of https://github.com/hightower8083/lasy i…

a32ca29

…nto t2z-z2t

hightower8083 and others added 2 commits June 28, 2023 15:44

fixed test t2z2t and removed debugging warnings

6e277fb

[pre-commit.ci] auto fixes from pre-commit.com hooks

d653245

for more information, see https://pre-commit.ci

MaxThevenet reviewed Jun 28, 2023

View reviewed changes

lasy/laser.py Outdated Show resolved Hide resolved

MaxThevenet reviewed Jun 28, 2023

View reviewed changes

lasy/laser.py Outdated Show resolved Hide resolved

Apply suggestions from code review

cc87b2d

MaxThevenet reviewed Jun 28, 2023

View reviewed changes

lasy/laser.py Outdated Show resolved Hide resolved

lasy/laser.py Outdated Show resolved Hide resolved

tests/test_t2z2t.py Outdated Show resolved Hide resolved

tests/test_t2z2t.py Outdated Show resolved Hide resolved

Apply suggestions from code review

1261b07

MaxThevenet approved these changes Jun 28, 2023

View reviewed changes

fix typos introduced in my previous commits

ca6cc87

MaxThevenet merged commit 41a7313 into LASY-org:development Jun 28, 2023

RemiLehe mentioned this pull request Jul 10, 2023

Further Improvements to Documentation #129

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement methods for conversion between temporal and spatial field presentations #126

Implement methods for conversion between temporal and spatial field presentations #126

hightower8083 commented Apr 21, 2023 •

edited

Loading

MaxThevenet left a comment

MaxThevenet commented May 15, 2023

MaxThevenet commented May 19, 2023

hightower8083 commented May 24, 2023 •

edited

Loading

MaxThevenet left a comment

MaxThevenet May 30, 2023

hightower8083 commented Jun 27, 2023

MaxThevenet left a comment

Implement methods for conversion between temporal and spatial field presentations #126

Implement methods for conversion between temporal and spatial field presentations #126

Conversation

hightower8083 commented Apr 21, 2023 • edited Loading

MaxThevenet left a comment

Choose a reason for hiding this comment

MaxThevenet commented May 15, 2023

MaxThevenet commented May 19, 2023

hightower8083 commented May 24, 2023 • edited Loading

MaxThevenet left a comment

Choose a reason for hiding this comment

MaxThevenet May 30, 2023

Choose a reason for hiding this comment

hightower8083 commented Jun 27, 2023

MaxThevenet left a comment

Choose a reason for hiding this comment

hightower8083 commented Apr 21, 2023 •

edited

Loading

hightower8083 commented May 24, 2023 •

edited

Loading