Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update writing of position #179

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Update writing of position #179

merged 2 commits into from
Sep 7, 2023

Conversation

RemiLehe
Copy link
Member

@RemiLehe RemiLehe commented Sep 7, 2023

The previous syntax for writing position was ambiguous about the type of position and could result in unreadable types when the lasy file is produced on certain architectures.

The new syntax now uses the default numpy type (float64).

@RemiLehe RemiLehe requested a review from ax3l September 7, 2023 16:59
@ax3l ax3l self-assigned this Sep 7, 2023
@ax3l ax3l added the bug Something isn't working label Sep 7, 2023
ax3l
ax3l reviewed Sep 7, 2023
View reviewed changes
@ax3l ax3l mentioned this pull request Sep 7, 2023
Closed
@RemiLehe @ax3l
Update lasy/utils/openpmd_output.py
c626865 
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
ax3l
ax3l approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@ax3l ax3l merged commit bdf7a1e into LASY-org:development Sep 7, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ax3l ax3l ax3l approved these changes

Assignees

@ax3l ax3l

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RemiLehe @ax3l