Fix complex interpolation in FromArrayProfile method #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…d" complex field `AMPLITUDE + 1J * PHASE`. Good result and 60% speedup
for more information, see https://pre-commit.ci
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with using scipy's
RegularGridInterpolatorwith complex numbers used inFromArrayProfile. While the amplitude and phase of the complex field normally vary smoothly in space and time, the real and imaginary parts typically strongly oscillate, which results in erroneous results.See here an example of the field read from measurement file: on the original grid (left) and with time axis refined by 4
This PR replaces the single interpolation operation with real-valued amplitude and phase (unwrapped along
t) interpolations. This fixes the issue with refined grid: