A fix to prevent division by zero during normalization #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have recently added
import_from_lasy
andexport_to_lasy
methods in axiprop and for the latter one I have used an empty profile to get it's field rewritten, i.e.:With this I've noticed that the normalization forced at initialization of
CombinedLongitudinalTransverseProfile
divides field by0.0
, and generates the corresponding warning. Although my methods work fine with this (None
field values are overwritten anyway), I don't like this warning.So this PR checks the energy before normalization and skips it if field is zero.