Add possibility to choose the number of points in theta #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
force-pushed
the
set_n_theta_evals
branch
from
1a259b6 to
fb3c47d
Compare
for more information, see https://pre-commit.ci
MaxThevenet
approved these changes
Jul 15, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new, optional parameter
n_theta_evals(see docstring in this PR.)For highly asymmetrical lasers, setting this to a high number can be important in order to obtain a good approximation of the laser pulse we projecting it onto few azimuthal modes (i.e. symmetrizing it).