Pass omega0 when applying optical element #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -184,7 +184,7 @@ | |||
| # The line below assumes that amplitude_multiplier | |||
| # is cylindrically symmetric, hence we pass | |||
| # `r` as `x` and 0 as `y` | |||
| multiplier = optical_element.amplitude_multiplier(r, 0, omega) | |||
| multiplier = optical_element.amplitude_multiplier(r, 0, omega, omega0) | |||
Check failure
Code scanning / CodeQL
Wrong number of arguments in a call Error
| @@ -196,7 +196,7 @@ | |||
| x, y, omega = np.meshgrid( | |||
| self.grid.axes[0], self.grid.axes[1], omega_1d, indexing="ij" | |||
| ) | |||
| spectral_field *= optical_element.amplitude_multiplier(x, y, omega) | |||
| spectral_field *= optical_element.amplitude_multiplier(x, y, omega, omega0) | |||
Check failure
Code scanning / CodeQL
Wrong number of arguments in a call Error
MaxThevenet
changed the title
soerenjalas
changed the title
RemiLehe
approved these changes
Jul 17, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For many optical elements the central laser frequency needs to be known. With this PR it is passed when calling
apply_opticsEdit: I turned OpticalElement into an abstract class to ensure that all child implementations of
amplitude_multiplierusex,y,omega,omega0as arguments. I'm also fine with reverting this if you don't like it.