Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

In-place NCCL allgather is incorrect #22

Closed
ndryden opened this issue Nov 22, 2018 · 0 comments · Fixed by #24
Closed

In-place NCCL allgather is incorrect #22

ndryden opened this issue Nov 22, 2018 · 0 comments · Fixed by #24
Labels
bug Something isn't working

Comments

@ndryden
Copy link
Collaborator

ndryden commented Nov 22, 2018 •
edited
Loading

This is similar to #21, except that our in-place allgather in NCCL is incorrect. (This actually causes test failures and differs from MPI.)
@ndryden ndryden added the bug Something isn't working label Nov 22, 2018
ndryden added a commit that referenced this issue Nov 24, 2018
@ndryden
Add tests for all collectives.
5ab2991 
This changes test_correctness to test_allreduces for consistency.

New argument passing added into test_utils.

Note that the allgather tests currently fail (see #22).
@ndryden ndryden mentioned this issue Nov 24, 2018
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix inplace allgather LLNL/Aluminum
1 participant
@ndryden