Updates on setup.py and sub-module definition #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two places in setup.py that errored out.
One is about checking gcc compiler name. Noe parameter is needed in _is_gcc() call.
The other is on external library definition. libgmp was missed. This caused "memsurfer/_memsurfer_cmod.so: undefined symbol: __gmpq_add" error.
These two parts are corrected in setup.py.
In the .sub-module defination, an https link is used for anonymous download.
Instruction is provided to install dependencies with conda.