Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Issue 637 fix #638

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Issue 637 fix #638

merged 3 commits into from
Jun 30, 2023

Conversation

nychiang
Copy link
Collaborator

Fix issue #637

CLOSE #637

@nychiang nychiang marked this pull request as ready for review June 23, 2023 06:42
@nychiang nychiang requested a review from cnpetra June 23, 2023 06:42
Copy link
Collaborator

@cnpetra cnpetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, we should clean up this code at some point

@@ -696,20 +706,23 @@ void hiopHessianLowRank::solveWithV(hiopMatrixDense& rhs)

hiopMatrixDense& sol = rhs; //matrix of solutions
/// TODO: get rid of these uses of specific hiopVector implementation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment since has been addressed

src/Optimization/hiopHessianLowRank.cpp Show resolved Hide resolved
@cnpetra cnpetra merged commit 6ad6695 into develop Jun 30, 2023
@cnpetra cnpetra mentioned this pull request Jun 30, 2023
@cnpetra cnpetra deleted the issue-637-fix branch September 11, 2023 17:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update the code after removing deepcheck in the dense linear algebra
2 participants