Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Pay form error state shows up on modal close #3016

Closed
bolatovumar opened this issue Oct 18, 2019 · 1 comment
Closed

Pay form error state shows up on modal close #3016

bolatovumar opened this issue Oct 18, 2019 · 1 comment
Assignees
@mrfelton
Labels
type: bug 🐛 Something isn't working
Milestone
v0.6.0-beta

Comments

@bolatovumar
Copy link
Contributor

This is super minor.

Pay form show error state momentarily when you close the pay form modal by clicking on the "close" icon. This is not an issue when you close the modal by "escape" key. See video here: https://youtu.be/-CX7MQ4b30I

Expected Behavior

Closing the pay modal doesn't trigger pay form input error state

Actual Behavior

Closing the pay modal triggers pay form field error state

Steps to Reproduce

    1. Click on "Pay" button
    1. Click on the "x" close icon in the top right corner
    1. Notice the red "failed" state shows up momentarily before the modal is closed

Your Environment

  • Zap version: 0.5.3
@mrfelton mrfelton added the type: bug 🐛 Something isn't working label Oct 26, 2019
@mrfelton mrfelton self-assigned this Oct 28, 2019
@mrfelton mrfelton added this to the v0.6.0-beta milestone Oct 28, 2019
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Oct 28, 2019
@mrfelton
fix(ui): no form error when form is empty
d0519bd 
Don't validate pay/request forms unless there are some values to
validate. This prevents the form showing errors when closing the modal
in the case that nothing has been entered into the form yet.

fix LN-Zap#3016
@mrfelton mrfelton mentioned this issue Oct 28, 2019
Merged
6 tasks
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Oct 28, 2019
@mrfelton
fix(ui): no form error when form is empty
d029992 
Don't validate pay/request forms unless there are some values to
validate. This prevents the form showing errors when closing the modal
in the case that nothing has been entered into the form yet.

fix LN-Zap#3016
@mrfelton
Copy link
Member

Closed via #3067

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@mrfelton mrfelton

Labels
type: bug 🐛 Something isn't working
Projects
None yet
Milestone
v0.6.0-beta
Development

No branches or pull requests
2 participants
@mrfelton @bolatovumar