Minor display issues on macOS

[sohomang]

Description

Here are some minor display issues. Some of them only appear on smaller screens (< 11") when using a different language than english.

I'm using macOS 10.15, haven't tested on Windows.

Details

Unasked newlines:

Could use more spacing / margin:

Unlike other modals, this one's left-aligned here but center-aligned on Zeplin:

[bolatovumar]

I will take a look into these.

[bolatovumar]

@sohomang I addressed all issues except for the last one

Unlike other modals, this one's left-aligned here but center-aligned on Zeplin:

I noticed that these modal headers are center-aligned when they are on a single line and left-aligned when they are on two or more lines. The reason you see it left aligned in your example is because it's on two lines. @mrfelton do you think I should go over all modals with headers of this kind and make them always center-aligned.

Also this:

Unasked newlines:

I made headers center-aligned here (Se connecter, for example). I thought of making it always on a single line and adjust header font size accordingly, however, this is a problem for languages that have long words like German. No way you can fit German headers on a single line.

[mrfelton]

I noticed that these modal headers are center-aligned when they are on a single line and left-aligned when they are on two or more lines. The reason you see it left aligned in your example is because it's on two lines. @mrfelton do you think I should go over all modals with headers of this kind and make them always center-aligned.

@bolatovumar - yes, I think we should make this consistently center aligned.

I made headers center-aligned here (Se connecter, for example). I thought of making it always on a single line and adjust header font size accordingly, however, this is a problem for languages that have long words like German. No way you can fit German headers on a single line.

Agreed - we only do dynamic font sizing in one place and causes alignment problems of it's own. Better to just the center the headers IMO.

[mrfelton]

Closed via #3049