feat(ui): implement activity item error dialog

[korhaliv]

Description:

Resolves #2580

How Has This Been Tested?

Manually

Screenshots (if appropriate):

Types of changes:

UX enhancement

Checklist:

• My code follows the code style of this project.
• I have reviewed and updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes where needed.
• All new and existing tests passed.
• My commits have been squashed into a concise set of changes.

[coveralls]

Coverage decreased (-0.02%) to 20.122% when pulling 9f07a74 on korhaliv:feat/activity-error-desc into ba74e0a on LN-Zap:next.

[mrfelton]

This needs a couple of tweaks IMO

1. it's not obvious it's a link or where you can/should click

2. The cursor needs to change to the pointer on hover which would as help identify it as a link

3. If we are going to use a dialog, the title of the dialog should probably not be An error has occurred - that makes me think an unrelated error occurred caused by me clicking on the link
   There was a problem sending your payment would be a better title

But actually I'm not convinced that a dialog is the best way to display this.

The dialog pattern feels more appropriate to display details of an error that just happened, rather than for retroactively displaying details about errors that happened in the past.

[mrfelton]

Code looks good and works well. I have 2 change requests though:

1. The cursor should change to a pointer on hover to make it more obvious that you can click on the text.

2. I don't think the modal should auto close when you copy the text. I asked to copy the error message, not close the window and by having the window closed automatically I now have to find the item in the activity list and click on it again to get back to where I was.

[korhaliv]

@mrfelton updated

[mrfelton]

Tested ACK 9f07a74