fix(ui): close channel create modal after channel opening is finished

[korhaliv]

Description:

Close Create channel modal after channel opening is finished (either successful or not). This functionality was broken some time during Modal Stack refactoring. Also remove redundant openChannel.data handler which was causing comlink error.

    grpc.services.Lightning.once(	
      'openChannel.data',	
      proxyValue(data => dispatch(pushchannelupdated(data)))	
    )

Is redundant because openChannel call resolves with exactly same data as per

zap-desktop/services/grpc/lightning.methods.js

Line 178 in 1044004

this.emit('openChannel.data', response)

Fix #2920

How Has This Been Tested?

Manually

Types of changes:

Bugfix

Checklist:

• My code follows the code style of this project.
• I have reviewed and updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes where needed.
• All new and existing tests passed.
• My commits have been squashed into a concise set of changes.

[coveralls]

Coverage increased (+0.008%) to 23.016% when pulling 1984974 on korhaliv:fix/channel-open into a40c13d on LN-Zap:next.

[mrfelton]

As per slack discussion, lets remove the unused events and do the same for closeChannel

[korhaliv]

@mrfelton updated

[mrfelton]

Minor thing here - can you ensure that each fix commit has a scope please for the changelogs. Thanks! missing from 1st commit in this PR.

[korhaliv]

@mrfelton updated

[mrfelton]

Tested ACK 1984974