Fix multi-protocol commitments merge-reveal and conceal procedures #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-orlovsky
added
bug
zoedberg
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
I've run the failing test 100 times and it always succeeded, so I think we can merge this. Thank you @dr-orlovsky :)
In these days we'll write some more tests to increase chances that everything works good and no more breaking changes will be needed.
|
The trickiest part were the problems happening when 3+ assets are involved. So I will also be working on increasing test coverage to scenarious above 100 assets. However, right now we can't have 100+ assets in a stable way b/c of #128 (we can't guarantee that all 100+ assets have a unique modulo divider within a scope of powers of two from 1 to 16). |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is downstream compilation non-breaking part of #127
NB: While it doesn't break compilation downstream, please keep in mind that it still breaks consensus rules, changes APIs (which were not yet used downstream) and invalidates existing stashes and inventories (i.e. stocks).