feat: feature strict encoding on monero types #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a feature `monero`, disable by default, implementing Strict Encode and Strict Decode on main Monero types from monero-rs/monero-rs.
dr-orlovsky
reviewed
Jul 6, 2022
strict_encoding/src/monero.rs
Outdated
Comment on lines
5
to
6
| // Dr. Maxim Orlovsky <orlovsky@pandoracore.com> | ||
| // h4sh3d <h4sh3d@protonmail.com> |
strict_encoding/src/monero.rs
Outdated
| impl StrictEncode for PaymentId { | ||
| #[inline] | ||
| fn strict_encode<E: io::Write>(&self, mut e: E) -> Result<usize, Error> { | ||
| Ok(e.write(&self.to_fixed_bytes())?) |
There was a problem hiding this comment.
We have impl StrictEncode for [T; const LEN], so you can just use self.to_fixed_bytes().strict_encode(e)
strict_encoding/src/monero.rs
Outdated
Comment on lines
203
to
205
| let mut bytes = [0u8; 8]; | ||
| d.read_exact(&mut bytes)?; | ||
| Ok(Self::from(bytes)) |
There was a problem hiding this comment.
Ibid: you can just say StrictDecode::strict_decode(d).map(Self::from)
strict_encoding/src/monero.rs
Outdated
Comment on lines
212
to
213
| self.major.strict_encode(&mut e)?; | ||
| self.minor.strict_encode(e) |
There was a problem hiding this comment.
There is a macro for that strict_encode_list!(e; self.major, self.minor)
strict_encoding/src/monero.rs
Outdated
Comment on lines
220
to
222
| let major = u32::strict_decode(&mut d)?; | ||
| let minor = u32::strict_decode(d)?; | ||
| Ok(Self { major, minor }) |
There was a problem hiding this comment.
Another macro strict_decode_self(d; major, minor)
strict_encoding/src/monero.rs
Outdated
Comment on lines
226
to
258
| impl StrictEncode for KeyPair { | ||
| #[inline] | ||
| fn strict_encode<E: io::Write>(&self, mut e: E) -> Result<usize, Error> { | ||
| self.view.strict_encode(&mut e)?; | ||
| self.spend.strict_encode(e) | ||
| } | ||
| } | ||
|
|
||
| impl StrictDecode for KeyPair { | ||
| #[inline] | ||
| fn strict_decode<D: io::Read>(mut d: D) -> Result<Self, Error> { | ||
| let view = PrivateKey::strict_decode(&mut d)?; | ||
| let spend = PrivateKey::strict_decode(d)?; | ||
| Ok(Self { view, spend }) | ||
| } | ||
| } | ||
|
|
||
| impl StrictEncode for ViewPair { | ||
| #[inline] | ||
| fn strict_encode<E: io::Write>(&self, mut e: E) -> Result<usize, Error> { | ||
| self.view.strict_encode(&mut e)?; | ||
| self.spend.strict_encode(e) | ||
| } | ||
| } | ||
|
|
||
| impl StrictDecode for ViewPair { | ||
| #[inline] | ||
| fn strict_decode<D: io::Read>(mut d: D) -> Result<Self, Error> { | ||
| let view = PrivateKey::strict_decode(&mut d)?; | ||
| let spend = PublicKey::strict_decode(d)?; | ||
| Ok(Self { view, spend }) | ||
| } | ||
| } |
There was a problem hiding this comment.
Here you can also use macros
dr-orlovsky
reviewed
Jul 8, 2022
| @@ -48,6 +53,7 @@ pub trait Strategy { | |||
| /// - [`BitcoinConsensus`] | |||
| /// - [`Wrapped`] | |||
| /// - [`UsingUniformAddr`] | |||
| /// - [`MoneroConsensus`] | |||
There was a problem hiding this comment.
This will fail on docs compiling w/o monero feature. We need
Suggested change
| /// - [`MoneroConsensus`] | |
| #[cfg_attr(feature = "monero", doc = "- [`MoneroConsensus`]")] |
dr-orlovsky
approved these changes
Jul 8, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a feature
monero, disable by default, implementing Strict Encode and Strict Decode on main Monero types from monero-rs/monero-rs.