Fix Taptree Strict Encode/Decode

[crisdut]

Description

I tried to use strict_decode in the PSBT file with output taptree and the method returns Error::DataIntegrityError.

This error occurs because the Taptree decode expected a different format. To simplify the process, I changed to use serialize and deserialize taptree provided by rust-bitcoin lib.

[dr-orlovsky]

Can you please provide the context in which you tried to serialize PSBT file? I mean was it a part of a wallet functionality, or something RGB-specific?

I think it was my mistake to start using strict_encoding all around, which results in things like this. My plan is to restrict it just to consensus-level stuff and to remove PSBTs and other structures which already have well-defined encodings. Please see #97 for the details.

I am also happy to merge this PR, but I assume that is a breaking change, requiring major version bump. So please provide where exactly you are using this and depending on that we will decide on the best strategy to fix the issue.

[crisdut]

Can you please provide the context in which you tried to serialize PSBT file? I mean was it a part of a wallet functionality, or something RGB-specific?

I found this bug when I made regression tests in tapret feature. When I tried to send a PSBT file with taptree in rgb-cli finalize operation, the node returned an error because strict_encode generated a different format than the strict_decode expected.

Without this fix, any PSBT file with taptree fails.

I think it was my mistake to start using strict_encoding all around, which results in things like this. My plan is to restrict it just to consensus-level stuff and to remove PSBTs and other structures which already have well-defined encodings. Please see #97 for the details.

WOW, I will check the proposal.

[dr-orlovsky]

ACK 3fc665b

[dr-orlovsky]

Thank you for the explanation, now I got it.

I think we can release that before 0.9 as a bugfix, since the previous version of the code didn't work anyway.

[dr-orlovsky]

Can you pls also do a PR against 0.8 branch such that we can do a bugfix release?

[crisdut]

Can you pls also do a PR against 0.8 branch such that we can do a bugfix release?

Sorry, do you refer the rgb-node repo?

[dr-orlovsky]

No, I refer to this repo, it has v0.8 branch which is a maintenance branch for 0.8.x fixes. Master already contains braking changes since 0.8 release and I can't publish 0.8.x versions from here.