Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed license code validation on 32-bit machines #3101

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

rinodrummer
Copy link
Contributor

Recently I mailed @tabacitu about a problem with the validation of a license code I purchased.

Even if the license code was correct, the validation function continued to show the unlicensed software notification on production.

After reading about the functions used in the script, Tabacitu noticed that the problem should have been related to the different value returned by crc32() on a 32-bit OS architecture which my hosting provider uses.

Following the instructions on the documentation page about that function, we figured out that the solution was using a combination of hexdec() and hash() function to simulate the crc32() algorithm.

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@tabacitu tabacitu merged commit cf075d1 into Laravel-Backpack:master Aug 5, 2020
@tabacitu
Copy link
Member

tabacitu commented Aug 5, 2020

Excellent! Thank you so much for the patience & help with this @rinodrummer ! I've also added an extra check on top of your PR - let me know if that breaks it for you in any way (it shouldn't, it only uses simple methods).

This will be available with the next patch update, most likely later today.
Cheers!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants