Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[4.1] Active class for navbar #3136

Merged
merged 3 commits into from
Aug 25, 2020
Merged

[4.1] Active class for navbar #3136

merged 3 commits into from
Aug 25, 2020

Conversation

martijnb92
Copy link
Contributor

active classes are automatically added to sidebar links. This small PR also enables that for links present in the navbar. In case someone uses the topbar_left_content.blade.php and topbar_right_content.blade.php.

Enable the active class for links in 'topbar_right_content.blade' and 'topbar_right_content.blade'
@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@martijnb92 martijnb92 changed the title Active class for navbar [4.1] Active class for navbar Aug 24, 2020
Copy link
Member

@tabacitu tabacitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works PERFECTLY! Thank you @martijnb92 !

@tabacitu tabacitu merged commit 3cbb598 into Laravel-Backpack:master Aug 25, 2020
@tabacitu
Copy link
Member

tabacitu commented Aug 25, 2020

Thanks a lot @martijnb92 , it's now merged, and it'll be available in Backpack 4.1.19 later today after I tag it. Please note that I've made a small change here #3151 let me know if you don't agree with it.

Cheers!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants