[4.1] Fix repeatable initialization #3148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The inspection completed: No new issues |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like we talked yesterday the best solution would be to split the container from the main form and add it later with JS.
Also added an js event
backpack_field.deletedthat allows us to do some cleanup when fields are deleted from page. In this specific scenario I applied it to ckeditor, allowing to fully destroy the ckinstances preventing js errors when ckeditor try to find unexistent instances.I tested in dummy, it worked great, please git a go a let me know.
Best,
Pedro