[Bug fix] allow the check column type to use the wrapper functionality #3158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this did not work because the wrapper was only output for screenreaders. Which doesn't makes sense, that's where you DON'T need the wrapper.
tabacitu
added
the
Minor Bug
|
The inspection completed: No new issues |
pxpm
approved these changes
Aug 31, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this did not work because the wrapper was only output for screen-readers. Which doesn't makes sense, that's where you DON'T need the wrapper. This allows one to change the checkbox color, and stuff like that:
@pxpm would you please double-check and review?